-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
BUG: Don't extract header names if none specified #23703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Don't extract header names if none specified #23703
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23703 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 161 161
Lines 51339 51339
=======================================
Hits 47360 47360
Misses 3979 3979
Continue to review full report at Codecov.
|
can you merge master. @chris-b1 can you take a look here |
cd037c8
to
4d0e2b3
Compare
Hello @gfyoung! Thanks for updating the PR.
|
Just to confirm, since they don't diff - none of the existing cases in the xlsx files were modified? Assuming no, looks good to me! |
@chris-b1 : I just added a new test to those Excel files. None of the existing tabs were modified. 👍 |
Alright, with three LGTM's, I think this is good to merge now. 🙂 |
Closes #11733.